Re: kern/48233

[Satoshi Yatagawa <yata_netbsd%y.haun.org@localhost>]

The following reply was made to PR kern/48233; it has been noted by GNATS.

From: Satoshi Yatagawa <yata_netbsd%y.haun.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: yata_netbsd%y.haun.org@localhost
Subject: Re: kern/48233
Date: Sat, 25 Mar 2017 22:30:48 +0900 (JST)

 I think that -current kernel (as of 7.99.66) have same problem again.
 
 "HP MicroServer Remote Access Card User Manual" says
 "The default system base address for the I/O mapped KCS Interface
 is 0xCA2 and is byte aligned at this system address.",
 
 but I think that a logic (introduced in src/sys/arch/x86/x86/ipmi.c
 rev 1.63) is not match to the address.
 
 The following patch fix this.
 
 Index: sys/arch/x86/x86/ipmi.c
 ===================================================================
 RCS file: /cvsroot/src/sys/arch/x86/x86/ipmi.c,v
 retrieving revision 1.64
 diff -u -r1.64 ipmi.c
 --- sys/arch/x86/x86/ipmi.c     7 Jul 2016 06:55:40 -0000       1.64
 +++ sys/arch/x86/x86/ipmi.c     25 Mar 2017 12:47:43 -0000
 @@ -942,7 +942,7 @@
             strcmp(platform, "ProLiant MicroServer") == 0 &&
             pipmi->smipmi_base_address != 0) {
                  ia->iaa_if_iospacing = 1;
 -                ia->iaa_if_iobase = pipmi->smipmi_base_address & ~0x7;
 +                ia->iaa_if_iobase = (pipmi->smipmi_base_address & ~0x7) - 6;
                  ia->iaa_if_iotype = 'i';
                  return;
          }
 
 My new kernel with this fix allows attaching as ipmi device again.
 
 % dmesg | grep ipmi0
 ipmi0 at mainbus0
 ipmi0: version 1.5 interface KCS iobase 0xca2/2 spacing 1