Re: kern/52070: Keyboard freeze after using touchpad

[Robert Elz <kre%munnari.OZ.AU@localhost>]

The following reply was made to PR kern/52070; it has been noted by GNATS.

From: Robert Elz <kre%munnari.OZ.AU@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/52070: Keyboard freeze after using touchpad
Date: Tue, 14 Mar 2017 21:28:52 +0700

     Date:        Tue, 14 Mar 2017 13:30:01 +0000 (UTC)
     From:        Martin Husemann <martin%duskware.de@localhost>
     Message-ID:  <20170314133001.98DA57A28E%mollari.NetBSD.org@localhost>
 
   |  Just to see if this gets us any further, could you try the patch below
   |  (and PMSDEBUG, ...)
 
 And the other debugs as well (PCKBCDEBUG etc).
 
 But I don't think the patch as is will help, it appears to #if 0
 away the:
                 if (pckbc_attach_slot(sc, PCKBC_AUX_SLOT))
                         cmdbits |= KC8_MENABLE;
 and if that doesn't happen nothing is likely improve things.
 
 So, Marc, try Martin's patch, but also try inserting
 
 #endif just before the two lines I included above, and #if 0
 immediately after (so those two lines effectively get excluded
 from the code that Martin suggests you try deleting.)
 
 kre
 
   |  
   |  Martin
   |  
   |  Index: pckbc.c
   |  ===================================================================
   |  RCS file: /cvsroot/src/sys/dev/ic/pckbc.c,v
   |  retrieving revision 1.59
   |  diff -u -p -r1.59 pckbc.c
   |  --- pckbc.c	14 Jul 2016 10:19:06 -0000	1.59
   |  +++ pckbc.c	14 Mar 2017 13:24:22 -0000
   |  @@ -278,13 +278,13 @@ pckbc_attach(struct pckbc_softc *sc)
   |   {
   |   	struct pckbc_internal *t;
   |   	bus_space_tag_t iot;
   |  -	bus_space_handle_t ioh_d, ioh_c;
   |  -	int res;
   |  +	bus_space_handle_t /* ioh_d, */ ioh_c;
   |  +	// int res;
   |   	u_char cmdbits = 0;
   |   
   |   	t = sc->id;
   |   	iot = t->t_iot;
   |  -	ioh_d = t->t_ioh_d;
   |  +	// ioh_d = t->t_ioh_d;
   |   	ioh_c = t->t_ioh_c;
   |   
   |   	t->t_pt = pckbport_attach(t, &pckbc_ops);
   |  @@ -348,6 +348,8 @@ pckbc_attach(struct pckbc_softc *sc)
   |   		goto nomouse;
   |   	}
   |   	t->t_haveaux = 1;
   |  +
   |  +#if 0
   |   	bus_space_write_1(iot, ioh_d, 0, 0x5a); /* a random value */
   |   	res = pckbc_poll_data1(t, PCKBC_AUX_SLOT);
   |   
   |  @@ -381,6 +383,7 @@ pckbc_attach(struct pckbc_softc *sc)
   |   #endif
   |   		t->t_haveaux = 0;
   |   	}
   |  +#endif
   |   
   |   nomouse:
   |   	/* enable needed interrupts */
   |  
   |