Re: kern/11018 (VIA VT83C572 UHCI USB controller does not work)

[Nick Hudson <skrll%netbsd.org@localhost>]

The following reply was made to PR kern/11018; it has been noted by GNATS.

From: Nick Hudson <skrll%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost, gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost,
 tsutsui%ceres.dti.ne.jp@localhost
Cc: 
Subject: Re: kern/11018 (VIA VT83C572 UHCI USB controller does not work)
Date: Thu, 16 Feb 2017 21:27:28 +0000

 This is a multi-part message in MIME format.
 --------------030407080908070603060708
 Content-Type: text/plain; charset=windows-1252; format=flowed
 Content-Transfer-Encoding: 7bit
 
 On 02/15/17 13:00, Izumi Tsutsui wrote:
 > The following reply was made to PR kern/11018; it has been noted by GNATS.
 >
 > From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
 > To: skrll%netbsd.org@localhost
 > Cc: gnats-bugs%NetBSD.org@localhost, tsutsui%ceres.dti.ne.jp@localhost
 > Subject: Re: kern/11018 (VIA VT83C572 UHCI USB controller does not work)
 > Date: Wed, 15 Feb 2017 21:54:51 +0900
 >
 >   > Does this patch help?
 >   
 >   Still gets "uhub0: device problem, disabling port 1"
 
 I gets further though. Maybe this patch helps more/as well.
 
 I'd be interested in results from both this patch alone and combined 
 with first one.
 
 Nick
 
 --------------030407080908070603060708
 Content-Type: text/x-patch;
  name="uhci.c.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="uhci.c.diff"
 
 Index: sys/dev/usb/uhci.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/usb/uhci.c,v
 retrieving revision 1.274
 diff -u -p -r1.274 uhci.c
 --- sys/dev/usb/uhci.c	4 Dec 2016 10:12:35 -0000	1.274
 +++ sys/dev/usb/uhci.c	16 Feb 2017 21:25:18 -0000
 @@ -2075,7 +2075,7 @@ uhci_reset_std_chain(uhci_softc_t *sc, s
  	status = UHCI_TD_ZERO_ACTLEN(UHCI_TD_SET_ERRCNT(3) | UHCI_TD_ACTIVE);
  	if (pipe->up_dev->ud_speed == USB_SPEED_LOW)
  		status |= UHCI_TD_LS;
 -	if (flags & USBD_SHORT_XFER_OK)
 +//	if (flags & USBD_SHORT_XFER_OK)
  		status |= UHCI_TD_SPD;
  	usb_syncmem(dma, 0, len,
  	    isread ? BUS_DMASYNC_PREREAD : BUS_DMASYNC_PREWRITE);
 
 --------------030407080908070603060708--