NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: port-sparc64/51925 (The sparc/sparc64 ports consider EM_SPARC32PLUS equivalent to EM_SPARCV9)



Hi!

On Tue, 2017-01-31 at 16:14:50 +0000, martin%NetBSD.org@localhost wrote:
> Synopsis: The sparc/sparc64 ports consider EM_SPARC32PLUS equivalent to EM_SPARCV9
> 
> Responsible-Changed-From-To: port-sparc64-maintainer->martin
> Responsible-Changed-By: martin%NetBSD.org@localhost
> Responsible-Changed-When: Tue, 31 Jan 2017 16:14:50 +0000
> Responsible-Changed-Why:
> Fixed, thanks for the report!
> 
> 
> State-Changed-From-To: open->closed
> State-Changed-By: martin%NetBSD.org@localhost
> State-Changed-When: Tue, 31 Jan 2017 16:14:50 +0000
> State-Changed-Why:
> I fixed it

Thanks! But I see you only modified the sparc64 tree. A similar entry
can be found in the sparc port, and although that one will just
fall through to an error case (I assume), it seems confusing given the
comment underneath. Also I think this is what caused the issue in the
sparc64, as the sparc tree was imported as a clone initially? So
fixing this would probably also avoid further confusion. :)

For reference, I'm talking about the following code:

  ,--- sys/arch/sparc/include/elf_machdep.h ---
  #define	ELF64_MACHDEP_ENDIANNESS	ELFDATA2MSB
  #define	ELF64_MACHDEP_ID_CASES					\
  		case EM_SPARC32PLUS:					\
  		case EM_SPARCV9:					\
  		/* no 64-bit ELF machine types supported */
  `---

Thanks,
Guillem



Home | Main Index | Thread Index | Old Index