NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: PR/51569 CVS commit: src/crypto/external/bsd/openssl/dist/crypto/bn/asm

The following reply was made to PR lib/51569; it has been noted by GNATS.

From: (Christos Zoulas)
To: Andreas Gustafsson <>
Cc:, coypu%SDF.ORG@localhost,
Subject: Re: PR/51569 CVS commit: src/crypto/external/bsd/openssl/dist/crypto/bn/asm
Date: Mon, 9 Jan 2017 10:52:50 -0500

 On Jan 9,  5:46pm, (Andreas Gustafsson) wrote:
 -- Subject: Re: PR/51569 CVS commit: src/crypto/external/bsd/openssl/dist/cry
 | Christos,
 | You wrote:
 | >  Log Message:
 | >  PR/51569: Andreas Gustafsson: Check the right bit for pclmulqdq:
 | >  Perform a Carry-Less Multiplication of Quadword instruction
 | >  (accelerator for GCM)
 | >  
 | >  To generate a diff of this commit:
 | >  cvs rdiff -u -r1.4 -r1.5 \
 | >      src/crypto/external/bsd/openssl/dist/crypto/bn/asm/
 | I think the actual root cause of this bug was the line
 |   -e 's/\(OPENSSL[A-Za-z0-9_]*\)(%rip)/\1@GOTPCREL(%rip)/' \
 | in src/crypto/external/bsd/openssl/lib/libcrypto/arch/x86_64/Makefile,
 | which you later removed in revision 1.11.
 | I think the change to worked simply because the added
 | "+4" caused the regexp not to match, so that the @GOTPCREL was not
 | added.  Other than that, it seems to me the old and new code should
 | give the same result (i.e., test the same bit).  Now that the
 | @GOTPCREL hack is gone from the Makefile, there should no longer be
 | any need for the change to, so I think it should be
 | reverted in the interest of keeping the differences wrt upstream
 | minimal.
 | I have a local change to revert the change - OK to
 | commit that and the corresponding regenerated .S file?
 If you can test it, go for it!

Home | Main Index | Thread Index | Old Index