Re: lib/51569: crypto tests randomly failing on amd64 with openssl 1.0.2j

[coypu%SDF.ORG@localhost]

The following reply was made to PR lib/51569; it has been noted by GNATS.

From: coypu%SDF.ORG@localhost
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: lib/51569: crypto tests randomly failing on amd64 with openssl
 1.0.2j
Date: Thu, 5 Jan 2017 13:44:48 +0000

 --pWyiEgJYm5f9v55/
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Hi,
 
 I can reproduce this on my pre-Westmere laptop.
 The attached diff seems to work for me, and seems to use
 the faster code for my newer desktop.
 
 --pWyiEgJYm5f9v55/
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="pclmul.diff"
 
 Index: x86_64/x86_64-gf2m.S
 ===================================================================
 RCS file: /cvsroot/src/crypto/external/bsd/openssl/lib/libcrypto/arch/x86_64/x86_64-gf2m.S,v
 retrieving revision 1.3
 diff -u -p -u -r1.3 x86_64-gf2m.S
 --- x86_64/x86_64-gf2m.S	14 Oct 2016 16:09:44 -0000	1.3
 +++ x86_64/x86_64-gf2m.S	5 Jan 2017 13:40:39 -0000
 @@ -202,8 +202,8 @@ _mul_1x1:
  .type	bn_GF2m_mul_2x2,@function
  .align	16
  bn_GF2m_mul_2x2:
 -	movq	OPENSSL_ia32cap_P@GOTPCREL(%rip),%rax
 -	btq	$33,%rax
 +	mov	OPENSSL_ia32cap_P+4(%rip),%eax
 +	bt	$1,%eax
  	jnc	.Lvanilla_mul_2x2
  
  .byte	102,72,15,110,198
 
 --pWyiEgJYm5f9v55/--