[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
PR/36997 CVS commit: src/sbin/ping
The following reply was made to PR bin/36997; it has been noted by GNATS.
From: "David A. Holland" <dholland%netbsd.org@localhost>
Subject: PR/36997 CVS commit: src/sbin/ping
Date: Sun, 18 Dec 2016 00:21:33 +0000
Module Name: src
Committed By: dholland
Date: Sun Dec 18 00:21:33 UTC 2016
PR bin/36997 Zafer Aydogan: ping doesn't validate numeric inputs enough.
Check for values between INT_MAX and LONG_MAX (if they're different)
when using strtol to get an int. This applies to the -c and -l options;
the other uses were already checked.
Also limit the inter-packet interval given with -i to values that
don't cause integer overflow calling poll() with milliseconds.
Really large intervals (the number is read as floating point) can
produce positive poll() values but negative integers when converted to
struct timespec; this produces behavior akin to using -l at first and
could be construed as a local DoS vulnerability.
To generate a diff of this commit:
cvs rdiff -u -r1.112 -r1.113 src/sbin/ping/ping.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Main Index |
Thread Index |