Re: kern/51574: src/sys/dev/usb/uhso.c:2167: confusing logic ?

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR kern/51574; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/51574: src/sys/dev/usb/uhso.c:2167: confusing logic ?
Date: Mon, 31 Oct 2016 05:16:02 +0000

 On Mon, Oct 24, 2016 at 04:05:00PM +0000, dcb314%hotmail.com@localhost wrote:
  > src/sys/dev/usb/uhso.c:2167]: (style) Expression is always false because 'else if' condition matches previous condition at line 2152.
  > 
  > Source code is
  > 
  >         if (got < want) {
  >             ..
  >         } else if (want > got) {
 
 That's obviously wrong, but it's not at all clear to me what should be
 there instead.
 
 Anyone who knows more than I do about the hardware want to comment?
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost