Re: port-i386/51358: /usr/bin/cvs fakes file permissions

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR port-i386/51358; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: port-i386/51358: /usr/bin/cvs fakes file permissions
Date: Mon, 1 Aug 2016 18:19:05 +0000

 On Mon, Aug 01, 2016 at 05:30:01PM +0000, Richard PALO wrote:
  > In my original test patch, I put ${TOOLS_SHELL} before
  > ${TOOLS_PATH} in TOOLS_SCRIPT.
  >  
  > I opted for the above since given the '?=' (it could possibly be
  > overridden), in which case it's not necessarily the pkgsrc
  > 'missing' being discussed.
 
 Right... might be something other than a shell script, so feeding it
 to the shell is wrong.
 
 This makes it all a pain.
 
 Is it limited to being one pathname, or is it legitimate for it to be
 a path in the $PATH sense? That would make it even more problematic.
 
  > Perhaps either holding off, or putting some execution logic in the
  > wrapper itself if test -x fails for POSIX shell scripts (or others)
  > is going to need to be done.
 
 One could put in something like
 
    if [ ! -x "${TOOLS_PATH.foo}" ]; then
 	TOOLS_INTERP.foo=$(${TOOL_SED} < "${TOOLS_PATH.foo}" -e 's/^#! *//;1q')
    fi
 
 but this is going to slow everything down a lot...
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost