Re: install/50357: Erroneous attempt to load booted file-system's module

[Paul Goyette <paul%whooppee.com@localhost>]

The following reply was made to PR install/50357; it has been noted by GNATS.

From: Paul Goyette <paul%whooppee.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: install/50357: Erroneous attempt to load booted file-system's
 module
Date: Fri, 10 Jun 2016 10:29:26 +0800 (PHT)

   This message is in MIME format.  The first part should be readable text,
   while the remaining parts are likely unreadable without MIME-aware tools.
 
 --0-538362010-1465525766=:25798
 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
 
 The attached patch checks the list of built-in modules for duplicates of 
 any module names pushed in from the boot-loader.  In the case of a 
 duplicate module name, we simply return an error status (no message is 
 logged unless you have previously set the module_verbose_on variable to 
 non-zero).  This avoids any attempt to resolve symbols from the module.
 
 While here, I'm also modifying another error message to differentiate 
 between failure-to-load and failure-to-get-module-info.
 
 I'll give folks a week or so to comment on the patch before I commit it.
 
 
 +------------------+--------------------------+------------------------+
 | Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:      |
 | (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com   |
 | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org |
 +------------------+--------------------------+------------------------+
 --0-538362010-1465525766=:25798
 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=km.diff
 Content-Transfer-Encoding: BASE64
 Content-ID: <Pine.NEB.4.64.1606101029260.25798%pokey.whooppee.com@localhost>
 Content-Description: 
 Content-Disposition: attachment; filename=km.diff
 
 SW5kZXg6IGtlcm5fbW9kdWxlLmMNCj09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0N
 ClJDUyBmaWxlOiAvY3Zzcm9vdC9zcmMvc3lzL2tlcm4va2Vybl9tb2R1bGUu
 Yyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTEwDQpkaWZmIC11IC1wIC1y
 MS4xMTAga2Vybl9tb2R1bGUuYw0KLS0tIGtlcm5fbW9kdWxlLmMJNiBGZWIg
 MjAxNiAyMjo0ODowNyAtMDAwMAkxLjExMA0KKysrIGtlcm5fbW9kdWxlLmMJ
 MTAgSnVuIDIwMTYgMDI6MjI6NTUgLTAwMDANCkBAIC0xMjM1LDcgKzEyMzUs
 OSBAQCBtb2R1bGVfZG9fdW5sb2FkKGNvbnN0IGNoYXIgKm5hbWUsIGJvb2wg
 DQogaW50DQogbW9kdWxlX3ByaW1lKGNvbnN0IGNoYXIgKm5hbWUsIHZvaWQg
 KmJhc2UsIHNpemVfdCBzaXplKQ0KIHsNCisJX19saW5rX3NldF9kZWNsKG1v
 ZHVsZXMsIG1vZGluZm9fdCk7DQogCW1vZHVsZV90ICptb2Q7DQorCW1vZGlu
 Zm9fdCAqY29uc3QgKm1pcDsNCiAJaW50IGVycm9yOw0KIA0KIAltb2QgPSBt
 b2R1bGVfbmV3bW9kdWxlKE1PRFVMRV9TT1VSQ0VfQk9PVCk7DQpAQCAtMTI0
 Myw2ICsxMjQ1LDE2IEBAIG1vZHVsZV9wcmltZShjb25zdCBjaGFyICpuYW1l
 LCB2b2lkICpiYXMNCiAJCXJldHVybiBFTk9NRU07DQogCX0NCiANCisJLyog
 Q2hlY2sgZm9yIGR1cGxpY2F0ZSBtb2R1bGVzICovDQorDQorCV9fbGlua19z
 ZXRfZm9yZWFjaChtaXAsIG1vZHVsZXMpIHsNCisJCWlmIChzdHJjbXAoKCpt
 aXApLT5taV9uYW1lLCBuYW1lKSA9PSAwKSB7DQorCQkJbW9kdWxlX3ByaW50
 KCJNb2R1bGUgYCVzJyBwdXNoZWQgYnkgYm9vdCBsb2FkZXIgIg0KKwkJCSAg
 ICAiYWxyZWFkeSBleGlzdHMuIiwgbmFtZSk7DQorCQkJcmV0dXJuIEVFWElT
 VDsNCisJCX0NCisJfQ0KKw0KIAllcnJvciA9IGtvYmpfbG9hZF9tZW0oJm1v
 ZC0+bW9kX2tvYmosIG5hbWUsIGJhc2UsIHNpemUpOw0KIAlpZiAoZXJyb3Ig
 IT0gMCkgew0KIAkJa21lbV9mcmVlKG1vZCwgc2l6ZW9mKCptb2QpKTsNCkBA
 IC0xMjU0LDggKzEyNjYsOCBAQCBtb2R1bGVfcHJpbWUoY29uc3QgY2hhciAq
 bmFtZSwgdm9pZCAqYmFzDQogCWlmIChlcnJvciAhPSAwKSB7DQogCQlrb2Jq
 X3VubG9hZChtb2QtPm1vZF9rb2JqKTsNCiAJCWttZW1fZnJlZShtb2QsIHNp
 emVvZigqbW9kKSk7DQotCQltb2R1bGVfZXJyb3IoInVuYWJsZSB0byBsb2Fk
 IGAlcycgcHVzaGVkIGJ5IGJvb3QgbG9hZGVyLCAiDQotCQkgICAgImVycm9y
 ICVkIiwgbmFtZSwgZXJyb3IpOw0KKwkJbW9kdWxlX2Vycm9yKCJ1bmFibGUg
 dG8gZmV0Y2hfaW5mbyBmb3IgYCVzJyBwdXNoZWQgYnkgYm9vdCAiDQorCQkg
 ICAgImxvYWRlciwgZXJyb3IgJWQiLCBuYW1lLCBlcnJvcik7DQogCQlyZXR1
 cm4gZXJyb3I7DQogCX0NCiANCg==
 
 --0-538362010-1465525766=:25798--