Re: install/51084: 'build.sh release' fails with MAKEVERBOSE >= 3

[Robert Elz <kre%munnari.OZ.AU@localhost>]

The following reply was made to PR install/51084; it has been noted by GNATS.

From: Robert Elz <kre%munnari.OZ.AU@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: install/51084: 'build.sh release' fails with MAKEVERBOSE >= 3
Date: Sat, 23 Apr 2016 02:18:48 +0700

     Date:        Fri, 22 Apr 2016 17:00:00 +0000 (UTC)
     From:        dieter roelants <dieter.NetBSD%pandora.be@localhost>
     Message-ID:  <20160422170000.F0B357AA95%mollari.NetBSD.org@localhost>
 
   |  Is it incorrect because you unset the vars for the rest of the script
   |  or because you lose a tiny bit of debug info?
 
 I think Paul meant that it is (probably) not the best, because there must
 be a better way...
 
 There's no problem about unsetting the vars, this function is only ever
 used (and only makes sense to be used) in a subshell, ie: as
 
 	MACHINE_CPU=$(arch_to_cpu ${MACHINE_ARCH})
 
 so the changes affect only the shell that runs the function, and not the
 parent.
 
 I doubt anyone much cares about the debug info from running this script either
 (if one needs to debug the setting of MACHINE_CPU I doubt that the way to
 do it would be to run a full release build with a high MAKEVERBOSE setting
 and then troll through the output...)
 
 I believe, the "fix" Paul gave works just fine - but it is so crude, and ugly,
 as well as being belt, braces, suspenders, and safety-pins (ie: just
 do everything that might influence the result, without caring which change
 actually makes things correct, or if several of them, individually, would
 be sufficient.)
 
 The objective of the PR is to get someone who actually understands what is
 going on with the build system to take a look at this, and fix it in an
 elegant way, rather than this crude hack...
 
 Incidentally, the "install" category of this PR isn't really right,
 but nor is "toolchain", or for that matter, anything else - a whole new
 gnats category might be warranted for build issues)
 
 kre