kern/50952: src/sys/lib/libsa/dosfs.c:569]: style) Suspicious condition

To: kern-bug-people%netbsd.org@localhost,gnats-admin%netbsd.org@localhost,netbsd-bugs%netbsd.org@localhost
Subject: kern/50952: src/sys/lib/libsa/dosfs.c:569]: style) Suspicious condition
From: dcb314%hotmail.com@localhost
Date: Fri, 11 Mar 2016 17:30:01 +0000 (UTC)

>Number:         50952
>Category:       kern
>Synopsis:       src/sys/lib/libsa/dosfs.c:569]:  style) Suspicious condition
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Mar 11 17:30:01 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160311
>Organization:
>Environment:
>Description:

src/sys/lib/libsa/dosfs.c:569]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.


Source code is

   if ((ok = xdn == 1)) {

Maybe better code

  if (((ok = (xdn == 1)) != 0) {


 


   

  



>How-To-Repeat:

>Fix:

Prev by Date: Re: kern/50949: src/sys/dev/pcmcia/if_malo_pcmcia.c:637]: (style) Suspicious condition
Next by Date: Re: kern/50949: src/sys/dev/pcmcia/if_malo_pcmcia.c:637]: (style) Suspicious condition
Previous by Thread: kern/50951: src/sys/fs/cd9660/cd9660_vnops.c:322]: style) Suspicious condition
Next by Thread: bin/50953: src/usr.bin/xstr/xstr.c:393]:style) Suspicious condition
Indexes:

Home | Main Index | Thread Index | Old Index