kern/50928: src/sys/arch/amiga/dev/sbic.c: 2 * suspicious condition ?

[dcb314%hotmail.com@localhost]

>Number:         50928
>Category:       kern
>Synopsis:       src/sys/arch/amiga/dev/sbic.c: 2 * suspicious condition ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 09 12:50:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160308
>Organization:
>Environment:
>Description:

1.

Source code is

src/sys/arch/amiga/dev/sbic.c:1999]: (style) Suspicious condition (bitwise operator + comparison); Clarify expression with parentheses.

    while(csr & 0x07 != MESG_OUT_PHASE) {

That could be tidier.

2.

src/sys/arch/amiga/dev/sbic.c:2007]: (style) Suspicious condition (bitwise operator + comparison); Clarify expression with parentheses.

   if( csr & 0x07 != MESG_OUT_PHASE ) {

Also in the same file

[src/sys/arch/amiga/dev/sbic.c:781]: (style) Variable 'asr' is assigned a value that is never used.
[src/sys/arch/amiga/dev/sbic.c:1128]: (style) Variable 'asr' is assigned a value that is never used.
[src/sys/arch/amiga/dev/sbic.c:717]: (style) Consecutive return, break, continue, goto or throw statements are unnecessary.

>How-To-Repeat:

>Fix: