NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

lib/50880: src/lib/libedit/terminal.c: two small problems



>Number:         50880
>Category:       lib
>Synopsis:       src/lib/libedit/terminal.c: two small problems
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lib-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 02 17:55:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160302
>Organization:
>Environment:
>Description:
[src/lib/libedit/terminal.c:381]: (style) Redundant condition: If 'EXPR != 0', the comparison 'EXPR != 0' is always true.

Source code is

        if (*tmp != NULL && *tmp != '\0' && *tmp != *str) {

Also,

[src/lib/libedit/terminal.c:668]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'size_t {aka unsigned long}'.

Source code is

        (void) fprintf(el->el_errfile,
            "%s: n is ridiculous: %d\r\n", __func__, n);

>How-To-Repeat:

>Fix:



Home | Main Index | Thread Index | Old Index