port-powerpc/50858: src/sys/arch/powerpc/isa/isadma_machdep.c: 2 * redundant conditions

[dcb314%hotmail.com@localhost]

>Number:         50858
>Category:       port-powerpc
>Synopsis:       src/sys/arch/powerpc/isa/isadma_machdep.c: 2 * redundant conditions
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-powerpc-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Feb 26 17:35:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160226
>Organization:
>Environment:
>Description:
1.


[src/sys/arch/powerpc/isa/isadma_machdep.c:299]: (style) Redundant condition: error!=0. 'error==0 || (error!=0 && (cookie.id_flags&1)==0)' is equivalent to 'error==0 || (cookie.id_flags&1)==0'


Source code is
 
   if (error == 0 ||
        (error != 0 && (cookie->id_flags & ID_MIGHT_NEED_BOUNCE) == 0))

2.

[src/sys/arch/powerpc/isa/isadma_machdep.c:371]: (style) Redundant condition: error!=0. 'error==0 || (error!=0 && (cookie.id_flags&1)==0)' is equivalent to 'error==0 || (cookie.id_flags&1)==0'

Source code is

    if (error == 0 ||
        (error != 0 && (cookie->id_flags & ID_MIGHT_NEED_BOUNCE) == 0))

 
>How-To-Repeat:

>Fix: