NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
port-arc/50855: src/sys/arch/arc/isa/isadma_bounce.c: 2 * redundant conditions
>Number: 50855
>Category: port-arc
>Synopsis: src/sys/arch/arc/isa/isadma_bounce.c: 2 * redundant conditions
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: port-arc-maintainer
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Fri Feb 26 17:25:00 +0000 2016
>Originator: David Binderman
>Release: cvs dated 20160226
>Organization:
>Environment:
>Description:
1.
[src/sys/arch/arc/isa/isadma_bounce.c:254]: (style) Redundant condition: error!=0. 'error==0 || (error!=0 && (cookie.id_flags&1)==0)' is equivalent to 'error==0 || (cookie.id_flags&1)==0'
Source code is
if (error == 0 ||
(error != 0 && (cookie->id_flags & ID_MIGHT_NEED_BOUNCE) == 0))
2.
[src/sys/arch/arc/isa/isadma_bounce.c:324]: (style) Redundant condition: error!=0. 'error==0 || (error!=0 && (cookie.id_flags&1)==0)' is equivalent to 'error==0 || (cookie.id_flags&1)==0'
Source code is
if (error == 0 ||
(error != 0 && (cookie->id_flags & ID_MIGHT_NEED_BOUNCE) == 0))
>How-To-Repeat:
>Fix:
Home |
Main Index |
Thread Index |
Old Index