bin/50821: src/usr.sbin/traceroute/traceroute.c:1247: strange expression ?

[dcb314%hotmail.com@localhost]

>Number:         50821
>Category:       bin
>Synopsis:       src/usr.sbin/traceroute/traceroute.c:1247: strange expression ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Feb 17 11:25:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160216
>Organization:
>Environment:
>Description:
[src/usr.sbin/traceroute/traceroute.c:1247]: (style) Same expression on both sides of '<'.


Source code is


     for (p = useicmp ? (u_char *)outicmp : (u_char *)outudp, i = 0; i <
        i < packlen - (sizeof(*outip) + optlen); i++)

Maybe better code might be

   for (p = useicmp ? (u_char *)outicmp : (u_char *)outudp, i = 0; 
        i < packlen - (sizeof(*outip) + optlen); i++)




>How-To-Repeat:

>Fix: