NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

port-sgimips/50783: src/sys/arch/sgimips/dev/crmfb.c:1132: break in wrong place ?

>Number:         50783
>Category:       port-sgimips
>Synopsis:       src/sys/arch/sgimips/dev/crmfb.c:1132: break in wrong place ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-sgimips-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 08 16:20:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160208
[src/sys/arch/sgimips/dev/crmfb.c:1132]: (style) Statements following return, break, continue, goto or throw will never be executed.

Source code is

        case 32:
            sc->sc_de_mode = DE_MODE_TLB_A | DE_MODE_BUFDEPTH_32 |
                DE_MODE_TYPE_RGBA | DE_MODE_PIXDEPTH_32;
            sc->sc_mte_mode = MTE_MODE_DST_ECC |
                (MTE_TLB_A << MTE_DST_TLB_SHIFT) |
                (MTE_TLB_A << MTE_SRC_TLB_SHIFT) |
                (MTE_DEPTH_32 << MTE_DEPTH_SHIFT);
            sc->sc_mte_x_shift = 2;

All the other cases set sc_de_mode, sc_mte_mode and
sc_mte_x_shift and then break.

Maybe this case should also.



Home | Main Index | Thread Index | Old Index