Re: PR/50638 CVS commit: src/sys/lib/libsa

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

> (1) The commit message is wrong, it has been clearly demonstrated that
> the CRC code *does* provide obvious side-effects.

I just noted a test result of "booting i386 kernel without the option."
If you see something that is obvious, can you file a new PR?

> (2) The offered patches fixes the stated original original problem to
> within a small degree of the cost of uncompression.

I see no reason to revert it because it isn't default.
Most ports require "smallest or fastet" and your patch doesn't
provide either.

> (3) Fixing the real problem of repeated uncompression would make (2)
> even less a problem.

Once you can provide real fixes, you can apply it independently.
Even in that case, "no CRC check" (or zlib version) is still
faster than yours.

---
Izumi Tsutsui