lib/50633: sys/ktrace.h not pulling-in all deps (params.h)

[bch <brad.harder%gmail.com@localhost>]

>Number:         50633
>Category:       lib
>Synopsis:       sys/ktrace.h not pulling all required deps
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 08 20:15:00 +0000 2016
>Originator:     bch <brad.harder%gmail.com@localhost>
>Release:        NetBSD 7.99.25
>Organization:
        method logic digital
>Environment:
System: NetBSD strathcona 7.99.25 NetBSD 7.99.25 (GENERIC) #211: Tue
Jan 5 10:17:33 PST 2016
root@strathcona:/usr/obj/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:
        pulling headers for ktrace(2) as descibed in the manpage and
trying to build a program results in:

/usr/include/sys/ktrace.h:67:16: error: 'MAXCOMLEN' undeclared here
(not in a function)
  char ktr_comm[MAXCOMLEN+1]; /* command name */
                ^
/usr/include/sys/ktrace.h:158:2: error: unknown type name 'sig_t'
  sig_t action;
  ^
/usr/include/sys/ktrace.h:159:2: error: unknown type name 'sigset_t'
  sigset_t mask;
  ^
>How-To-Repeat:

#include <sys/types.h>
#include <sys/uio.h>
#include <sys/ktrace.h>

int
main (int argc, char *argv[]) {
  return 0;
}

>Fix:


--- ./sys/ktrace.old    2016-01-08 11:58:02.000000000 -0800
+++ ./sys/ktrace.h      2016-01-08 12:06:32.000000000 -0800
@@ -36,6 +36,8 @@

 #include <sys/mutex.h>
 #include <sys/lwp.h>
+#include <sys/param.h>

 /*
  * operations to ktrace system call  (KTROP(op))