Re: kern/50601: sparc64 with root-on-raid0 does not reboot

[mlelstv%serpens.de@localhost (Michael van Elst)]

The following reply was made to PR kern/50601; it has been noted by GNATS.

From: mlelstv%serpens.de@localhost (Michael van Elst)
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/50601: sparc64 with root-on-raid0 does not reboot
Date: Wed, 30 Dec 2015 23:58:03 +0000 (UTC)

 martin%duskware.de@localhost (Martin Husemann) writes:
 
 > Does anyone see what causes the duplicate detach messages?
 
 The duplicate detach message comes from printing it in the
 detach code and automatically printing it in the shutdown
 code where config_detach() isn't called with DETACH_QUIET.
 
 > Martin
 > 
 > Index: rf_netbsdkintf.c
 > ===================================================================
 > RCS file: /cvsroot/src/sys/dev/raidframe/rf_netbsdkintf.c,v
 > retrieving revision 1.330
 > diff -u -r1.330 rf_netbsdkintf.c
 > --- rf_netbsdkintf.c	26 Dec 2015 21:50:43 -0000	1.330
 > +++ rf_netbsdkintf.c	30 Dec 2015 20:00:55 -0000
 > @@ -3938,6 +3938,8 @@
 >  		return (error);
 >  
 >  	error = raid_detach_unlocked(rs);
 > +	if (error)
 > +		raidunlock(rs);
 
 Moving raidunlock (and raidput) out of raid_detach_unlocked
 is easier to understand. I.e.:
 
         if ((error = raidlock(rs)) != 0)
                 return (error);
 
         error = raid_detach_unlocked(rs);
 
         raidunlock(rs);
 
         if (error)
                 return error;
         
         /* Free the softc */
         raidput(rs);
 
         return 0;
 
 
 -- 
 -- 
                                 Michael van Elst
 Internet: mlelstv%serpens.de@localhost
                                 "A potential Snark may lurk in every tree."