NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

install/50580: src/distrib/cdrom/macppc_mkboothfs/mkboothfs.c: 3 * performance problem ?



>Number:         50580
>Category:       install
>Synopsis:       src/distrib/cdrom/macppc_mkboothfs/mkboothfs.c: 3 * performance problem ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    install-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Dec 22 19:35:00 +0000 2015
>Originator:     David Binderman
>Release:        cvs dated 20151222
>Organization:
>Environment:
>Description:
1.


[src/distrib/cdrom/macppc_mkboothfs/mkboothfs.c:86] -> [src/distrib/cdrom/macppc_mkboothfs/mkboothfs.c:87]: (performance) Buffer 'buf' is being written before its old content has been used.

    memset(buf, 0, BSIZE);
    memcpy(buf, &dm, sizeof(dm));

2.

[src/distrib/cdrom/macppc_mkboothfs/mkboothfs.c:107] -> [src/distrib/cdrom/macppc_mkboothfs/mkboothfs.c:108]: (performance) Buffer 'buf' is being written before its old content has been used.

    memset(buf, 0, BSIZE);
    memcpy(buf, &pme, sizeof(pme));

3.

[src/distrib/cdrom/macppc_mkboothfs/mkboothfs.c:117] -> [src/distrib/cdrom/macppc_mkboothfs/mkboothfs.c:118]: (performance) Buffer 'buf' is being written before its old content has been used.

    memset(buf, 0, BSIZE);
    memcpy(buf, &pme, sizeof(pme));

>How-To-Repeat:

>Fix:



Home | Main Index | Thread Index | Old Index