Re: kern/50571: src/sys/fs/udf/udf_subr.c:6465: obvious performance tidyup

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR kern/50571; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/50571: src/sys/fs/udf/udf_subr.c:6465: obvious performance
 tidyup
Date: Sat, 19 Dec 2015 03:10:13 +0000

 On Sat, Dec 19, 2015 at 02:55:01AM +0000, Robert Elz wrote:
  >  Aside from the question of whether it should have been done, you also
  >  just inserted the code supplied in the initial PR from dcb314%hotmail.com@localhost
  >  which leaves blob[0 ..  pos-1] uninitialised.
 
 It's not memcpying to blob + pos, it's memcpying to blob. "pos" is the
 source pointer.
 
 boo on confusing names.
 
 (that the code also didn't compile is perhaps another issue but it's
 been fixed already)
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost