Re: PR/50428 CVS commit: src/sys/compat/linux

[Rin Okuyama <okuyama%flex.phys.tohoku.ac.jp@localhost>]

The following reply was made to PR kern/50428; it has been noted by GNATS.

From: Rin Okuyama <okuyama%flex.phys.tohoku.ac.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost, Christos Zoulas <christos%netbsd.org@localhost>
Cc: 
Subject: Re: PR/50428 CVS commit: src/sys/compat/linux
Date: Wed, 16 Dec 2015 17:31:25 +0900

 Triggered by this change, an uninitialized-variable defect, CID 980928,
 was found by Coverity.
 
   http://mail-index.netbsd.org/coverity-updates/2015/11/23/msg000196.html
 
 Please apply the attached patch. I've tested it on i386 and amd64.
 
 --- src/sys/compat/linux/common/linux_signal.c.orig	2015-12-04 07:07:37.000000000 +0900
 +++ src/sys/compat/linux/common/linux_signal.c	2015-12-04 07:10:47.000000000 +0900
 @@ -355,7 +355,8 @@
  		obsa.sa_flags = 0;
  	} else {
  #ifdef LINUX_SA_RESTORER
 -		if ((nlsa.linux_sa_flags & LINUX_SA_RESTORER) &&
 +		if (SCARG(uap, nsa) &&
 +		    (nlsa.linux_sa_flags & LINUX_SA_RESTORER) &&
  		    (tramp = nlsa.linux_sa_restorer) != NULL)
  				vers = 2;
  #endif