kern/50527: src/sys/dev/pci/if_wm.c:3108: bad test ?

[dcb314%hotmail.com@localhost]

>Number:         50527
>Category:       kern
>Synopsis:       src/sys/dev/pci/if_wm.c:3108: bad test ?
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Dec 11 09:50:00 +0000 2015
>Originator:     David Binderman
>Release:        cvs dated 20151210
>Organization:
>Environment:
>Description:
[src/sys/dev/pci/if_wm.c:3108]: (style) Expression '(X & 0xe) == 0x1' is always false.

  if (sc->sc_type == WM_T_82544 && (reg & 0xe) == 1) {

Another case of wrong code on initial inspection.

>How-To-Repeat:

>Fix: