[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: port-xen/49919: Bugs in xenevt.c
The following reply was made to PR port-xen/49919; it has been noted by GNATS.
From: Manuel Bouyer <bouyer%antioche.eu.org@localhost>
Cc: port-xen-maintainer%NetBSD.org@localhost, gnats-admin%NetBSD.org@localhost,
Subject: Re: port-xen/49919: Bugs in xenevt.c
Date: Fri, 22 May 2015 12:32:00 +0200
On Fri, May 22, 2015 at 10:10:07AM +0000, liuw%liuw.name@localhost wrote:
> 1. The critical region is too small in xenevt_fread.
Why do you think it's too small ? The code not covered by the
lock only manipulates local (on-stack) variables.
> 2. Range check under IOCTL_EVTCHN_UNBIND should be ">=".
> 3. Range check under IOCTL_EVTCHN_NOTIFY should be ">=".
Right, there's a off-by-one error. There's also one in xenevt_fwrite().
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
NetBSD: 26 ans d'experience feront toujours la difference
Main Index |
Thread Index |