NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: standards/49435 (Remove trailing blank characters from the code-base)



The following reply was made to PR standards/49435; it has been noted by GNATS.

From: "Kamil Rytarowski" <n54%gmx.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: jakllsch%NetBSD.org@localhost
Subject: Re: standards/49435 (Remove trailing blank characters from the
 code-base)
Date: Fri, 26 Dec 2014 04:28:22 +0100

 > State-Changed-From-To: open->closed
 > State-Changed-By: jakllsch%NetBSD.org@localhost
 > State-Changed-When: Fri, 26 Dec 2014 02:31:24 +0000
 > State-Changed-Why:
 > won't fix.  3rd party code will not be touched this way, however original code may be fixed incrementally as the files are touched or as deemed appropriate
 > 
 
 Hello,
 
 Thanks for feedback.. I consider closing this ticked as premature..
 
 This change was assumed for our code, never for 3rd party!
 
 I consider it as much more work then for just fixing it as files are touched, the code is literally polluted to the extend that I don't know if I should fix new lines or the code...
 
 Trying out pristine -current, under git:
 
 find /usr/src/sys/arch/ -name '*.[ch]' -exec perl -pli -e "s/\s*$//" {} \;
 
 $ git diff|wc -l
   10334
 
 Yes, diff between version before and after of just src/sys/arch is long for over 10k lines.
 
 Better to fix it globally now then suffer with it forever.
 I personally doubt that trailing white symbols are ever appropriate in a C code.
 
 Best regards,
 


Home | Main Index | Thread Index | Old Index