NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/47881 (kernel diagnostic assertion "c->c_cpu->cc_lwp == curlwp || c->c_cpu->cc_active != c" failed)

On Tue, Nov 11, 2014 at 5:30 PM, Martin Husemann <> wrote:
On Tue, Nov 11, 2014 at 05:18:56PM +0900, Ryota Ozaki wrote:
> +               callout_halt(&in6m->in6m_timer_ch, softnet_lock);
>                 callout_destroy(&in6m->in6m_timer_ch);

Certainly a valid change - IMHO all callout_destroy() should have an
explicit callout_halt() unless we can be 100% sure no callout is in flight
for other reasons (which probably warrants a comment at the callout_destroy

Thank you for your checking. I'll commit the path later.

BTW, there are many callout_stop & callout_destroy. Should we replace them
with callout_halt & callout_destroy?


Home | Main Index | Thread Index | Old Index