Re: kern/49076: USB 3.0 devices are not attached to xhci hubs

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

The following reply was made to PR kern/49076; it has been noted by GNATS.

From: Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/49076: USB 3.0 devices are not attached to xhci hubs
Date: Sun, 31 Aug 2014 15:14:33 +0900 (JST)

 Hi,
 
 In addition, the following patch enables
 MacBook 2014's Lynx Point-LP's USB 3.0 ports.
 
 Lynx Point-LP may never enable interrupt pending flag.
 
 Index: xhci.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/usb/xhci.c,v
 retrieving revision 1.20
 diff -u -r1.20 xhci.c
 --- xhci.c     26 Jul 2014 00:17:57 -0000      1.20
 +++ xhci.c     31 Aug 2014 06:09:58 -0000
 @@ -890,9 +890,11 @@
  
        iman = xhci_rt_read_4(sc, XHCI_IMAN(0));
        //device_printf(sc->sc_dev, "%s IMAN0 %08x\n", __func__, iman);
 +#if 0
        if ((iman & XHCI_IMAN_INTR_PEND) == 0) {
                return 0;
        }
 +#endif
        xhci_rt_write_4(sc, XHCI_IMAN(0), iman);
        iman = xhci_rt_read_4(sc, XHCI_IMAN(0));
        //device_printf(sc->sc_dev, "%s IMAN0 %08x\n", __func__, iman);
 
 MacBook have internal non-root hub, and it seems that
 our xhci implementation has no non-root hub support sadly...
 So I cannot confirm the real functionality, but dmesg shows umass(4).
 (MacBook's keyboard is connected to internal non-root hub.)
 
 --
 Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
 PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3