Re: kern/46464: lib/librumphijack/t_tcpip:ssh test case randomly fails

[Antti Kantee <pooka%NetBSD.org@localhost>]

The following reply was made to PR kern/46464; it has been noted by GNATS.

From: Antti Kantee <pooka%NetBSD.org@localhost>
To: Andreas Gustafsson <gson%gson.org@localhost>
Cc: gnats-bugs%NetBSD.org@localhost
Subject: Re: kern/46464: lib/librumphijack/t_tcpip:ssh test case randomly
 fails
Date: Sat, 19 Jul 2014 10:13:18 +0000

 On 19/07/14 09:11, Andreas Gustafsson wrote:
 > Hi Antti,
 >
 > I have now tracked down the cause of PR 46464 to an assertion failure
 > in librumphijack:
 >
 >    assertion "(pfd_rump[nfds].revents & POLLIN) == 0" failed: file 
 > "/tmp/bracket/build/2014.07.16.07.41.43-i386-debug/src/lib/librumphijack/hijack.c",
 >  line 2073, function "_sys___pollts50"
 >
 > What is the intent of the assertion?  It seems to be asserting that
 > the two threads can't simultaneously notify each other, but it looks
 > like they can.
 
 Andreas,
 
 I am almost sure you are correct.  The rest of the code seems to handle 
 two polls finishing correctly, too.  That assert and the same one in 
 another branch a few lines lower should be removed.
 
 thanks!