NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/48808

The following reply was made to PR kern/48808; it has been noted by GNATS.

From: "Thomas Schmitt" <>
Subject: Re: kern/48808
Date: Sun, 18 May 2014 16:25:43 +0200

 I answered to myself the rest of the XXX questions.
 - Nobody objected adding 120 bytes on the stack. So it stays
   this way. No clean-up code against memory leaks is needed.
 - I will submit the proposal to reject unknown ISOFSMNT_* flags
   as a separate PR. The comment is still in my proposed change.
 - I leave the remarks about the non-operation of MNT_UPDATE
   for somebody who has more clue about how this is supposed to
   work. Currently and after my change, it silently does nothing.
 - I added ISOFSMNT_NOCASETRANS to the memorized mount flags in
   struct iso_mnt.im_flags.
 Further i adapted ISOFSMNT_BITS to the "new formatting style" example
 in man 9 snprintb. (It does not solve the ugly output "0x0>"
 of -o getargs on a default mount.)
 To Martin Husemann:
 > Forward binary compat like this is not needed - a new mount_cd9660 binary
 > can expect a new kernel always.
 Shall i understand "is not needed" as "is not desirable" and remove
 the after-mount test in mount_cd9660(8) ?
 To other commenters:
 If you are not satisfied with my reactions, then please tell.
 I will now send two refurbished change proposals for sys/fs/cd9660
 and sbin/mount_9660. I deem them ready for committer review.
 The patch proposal
   Date: Wed, 14 May 2014 11:15:36 +0200
 stays valid.

Home | Main Index | Thread Index | Old Index