port-arm/48543: Fix modload failure on evbarm/BEAGLEBONE

[ozaki-r%iij.ad.jp@localhost]

>Number:         48543
>Category:       port-arm
>Synopsis:       Fix modload failure on evbarm/BEAGLEBONE
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    port-arm-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 23 11:20:00 +0000 2014
>Originator:     Ryota Ozaki
>Release:        current
>Organization:
IIJ
>Environment:
# uname -a
NetBSD  6.99.29 NetBSD 6.99.29 (BEAGLEBONE) #114: Thu Jan 23 19:18:05 JST 2014  
ozaki-r@(snip) evbarm

>Description:
Modules that use ffs cannot be modload-ed; modload fails with the following 
error:
  # modload nand
  kobj_checksyms, 880: [nand]: linker error: symbol `__ffssi2' not found
  WARNING: module error: unable to affix module `nand', error 8
  modload: Exec format error

The kernel binary includes ffs and __ffssi2 symbols, however, its code is not 
found.
>How-To-Repeat:
I guess we can reproduce the problem with any evbarm/BEAGLEBONE kernels.
>Fix:
Index: common/lib/libc/arch/arm/string/ffs.S
===================================================================
RCS file: /cvs/cvsroot/src/common/lib/libc/arch/arm/string/ffs.S,v
retrieving revision 1.6
diff -u -r1.6 ffs.S
--- common/lib/libc/arch/arm/string/ffs.S       30 Sep 2013 13:07:51 -0000      
1.6
+++ common/lib/libc/arch/arm/string/ffs.S       23 Jan 2014 10:43:48 -0000
@@ -44,7 +44,7 @@
  * This is the ffs algorithm devised by d.seal and posted to comp.sys.arm on
  * 16 Feb 1994.
  */
-WEAK_ALIAS(__ffssi2,ffs)
+STRONG_ALIAS(__ffssi2,ffs)
 #if (defined(_ARM_ARCH_5) && !defined(__thumb__)) || defined(_ARM_ARCH_T2)
 #if defined(_ARM_ARCH_T2)
 ENTRY(ffs)