kern/48366: xhci without DIAGNOSTIC may panic

[Takahiro HAYASHI <t-hash%abox3.so-net.ne.jp@localhost>]

>Number:         48366
>Category:       kern
>Synopsis:       xhci without DIAGNOSTIC may panic
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Nov 04 08:05:00 +0000 2013
>Originator:     Takahiro HAYASHI
>Release:        NetBSD 6.99.25 (2013.11.03.08.51.23 UTC)
>Organization:
>Environment:
System: NetBSD ruin 6.99.25 NetBSD 6.99.25 (UNION) #3: Sun Nov  3 19:07:53 JST 
2013 root@halt:/build/head/obj.amd64/sys/arch/amd64/compile/UNION amd64
Architecture: x86_64
Machine: amd64
>Description:
        kernel built without DIAGNOSTIC may panic around xhci.

        xhci_allocx() fills allocated xfer memory with zero only with
        DIAGNOSTIC, but {u,o,e}hci_allocx() always do.
        xhci_allocx() should do it always too, or allocated memory
        is uninitialized if not DIAGNOSTIC defined.

>How-To-Repeat:

>Fix:
        Please move memset() out of #ifdef DIAGNOSTIC in xhci_allocx()
        if you want to build kernel w/o DIAGNOSTIC.

--
t-hash