Re: kern/48277: Booting under KVM yields panic: siop_intr: I shouldn't be there !

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

The following reply was made to PR kern/48277; it has been noted by GNATS.

From: Manuel Bouyer <bouyer%antioche.eu.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: kern-bug-people%NetBSD.org@localhost, gnats-admin%NetBSD.org@localhost, 
netbsd-bugs%NetBSD.org@localhost,
        Andreas Gustafsson <gson%gson.org@localhost>
Subject: Re: kern/48277: Booting under KVM yields panic: siop_intr: I
 shouldn't be there !
Date: Sun, 6 Oct 2013 23:31:35 +0200

 On Sun, Oct 06, 2013 at 09:00:01PM +0000, Martin Husemann wrote:
 > The following reply was made to PR kern/48277; it has been noted by GNATS.
 > 
 > From: Martin Husemann <martin%duskware.de@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc: 
 > Subject: Re: kern/48277: Booting under KVM yields panic: siop_intr: I 
 > shouldn't be there !
 > Date: Sun, 6 Oct 2013 22:58:15 +0200
 > 
 >  The printf should be conditionalized on SIOP_DEBUG_INTR and the return
 >  should be "return retval;" - otherwise the change looks good enough to
 >  go in.
 >  
 >  A panic is very unfriendly here, even if the interrupt status reported
 >  does not match the remainder of the hardware status here.
 
 No, if you want to remove the panic the printf should stay
 inconditionally.
 I you get in this situation while running on real hardware, at best the
 hardware is not recoverable, at worse it can misbehave bad enough to damage
 some other memory region. A message on the console is mandadory, and a panic
 looks appropriate to me in this case.
 
 -- 
 Manuel Bouyer <bouyer%antioche.eu.org@localhost>
      NetBSD: 26 ans d'experience feront toujours la difference
 --