Re: misc/47827: [PATCH] improve portability of NetBSD libc testcases

[Garrett Cooper <yaneurabeya%gmail.com@localhost>]

On May 17, 2013, at 1:24 PM, Simon J. Gerraty wrote:

> On Fri, 17 May 2013 13:17:47 -0400, Garrett Cooper writes:
>>> @@ -1 +1,3 @@
>>> +CFLAGS+=3D -I${.CURDIR:H:H}
>>> +
>> 
>>      I forgot that NetBSD has a more sane (and correct) way of =
>> representing this:
>> 
>> CFLAGS+=3D   -I${NETBSDSRCDIR}/tests
> 
> The reason I use SRCTOP to represent the top of the src tree is, that it
> is generic and thus portable from one project to another.

Ok.

>>      The above form works for me because I can't go more than two =
>> levels deep in the libc tests directory I've imported because of missing =
>> build changes in FreeBSD that I'm not willing/able to fix quite yet as =
>> our copy of bsd.progs.mk doesn't support directory traversal and =
>> specifying PROG*/SCRIPTS* out of the box.
> 
> I committed the patch you sent recently - is this something else?

Yeah, it's something else we can discuss while we're both here at BSDCan :).
Thanks!
-Garrett