NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/47646: Test dev/scsipi/t_cd:noisyeject broken

The following reply was made to PR kern/47646; it has been noted by GNATS.

From: Martin Husemann <>
Cc: Manuel Bouyer <>
Subject: Re: kern/47646: Test dev/scsipi/t_cd:noisyeject broken
Date: Fri, 15 Mar 2013 11:03:53 +0100

 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 And this patch works around it - looks like somewhere on the way an
 error return value from cdstrategy is lost. With this change, the
 feature_len comes up as 0 and we break out of the loop imediately.
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=patch
 Index: cd.c
 RCS file: /cvsroot/src/sys/dev/scsipi/cd.c,v
 retrieving revision 1.309
 diff -u -r1.309 cd.c
 --- cd.c       6 May 2012 17:23:10 -0000       1.309
 +++ cd.c       15 Mar 2013 10:00:32 -0000
 @@ -3030,6 +3030,7 @@
                /* determine mmc profile and class */
                flags = XS_CTL_DATA_IN;
                memset(&gc_cmd, 0, sizeof(gc_cmd));
 +              _lto4b(0, gc->data_len);
                gc_cmd.opcode = GET_CONFIGURATION;
                _lto2b(last_feature, gc_cmd.start_at_feature);
                _lto2b(feat_tbl_len, gc_cmd.data_len);

Home | Main Index | Thread Index | Old Index