Re: kern/47514: Multiple dump -X triggers kernel panic in fss_ioctl

["J. Hannken-Illjes" <hannken%eis.cs.tu-bs.de@localhost>]

The following reply was made to PR kern/47514; it has been noted by GNATS.

From: "J. Hannken-Illjes" <hannken%eis.cs.tu-bs.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/47514: Multiple dump -X triggers kernel panic in fss_ioctl
Date: Wed, 30 Jan 2013 11:35:12 +0100

 --Apple-Mail=_B5B3A17D-6C5A-418D-87AF-705EBFBC1375
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
        charset=us-ascii
 
 Please try the attached patch.  If you are not able to build a kernel
 please drop me a note containing the output of "uname -a".
 
 --
 J. Hannken-Illjes - hannken%eis.cs.tu-bs.de@localhost - TU Braunschweig 
(Germany)
 
 
 --Apple-Mail=_B5B3A17D-6C5A-418D-87AF-705EBFBC1375
 Content-Disposition: attachment;
        filename=fss.c.diff
 Content-Type: application/octet-stream;
        name="fss.c.diff"
 Content-Transfer-Encoding: 7bit
 
 Index: fss.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/fss.c,v
 retrieving revision 1.83
 diff -p -u -2 -r1.83 fss.c
 --- fss.c      28 Jul 2012 16:14:17 -0000      1.83
 +++ fss.c      30 Jan 2013 10:33:15 -0000
 @@ -224,4 +224,5 @@ fss_close(dev_t dev, int flags, int mode
        error = 0;
  
 +      mutex_enter(&fss_device_lock);
  restart:
        mutex_enter(&sc->sc_slock);
 @@ -229,4 +230,5 @@ restart:
                sc->sc_flags &= ~mflag;
                mutex_exit(&sc->sc_slock);
 +              mutex_exit(&fss_device_lock);
                return 0;
        }
 @@ -240,10 +242,7 @@ restart:
        if ((sc->sc_flags & FSS_ACTIVE) != 0) {
                mutex_exit(&sc->sc_slock);
 +              mutex_exit(&fss_device_lock);
                return error;
        }
 -      if (! mutex_tryenter(&fss_device_lock)) {
 -              mutex_exit(&sc->sc_slock);
 -              goto restart;
 -      }
  
        KASSERT((sc->sc_flags & FSS_ACTIVE) == 0);
 
 --Apple-Mail=_B5B3A17D-6C5A-418D-87AF-705EBFBC1375--