Re: PR/41267 CVS commit: src/sys/arch/x86/x86

["Greg A. Woods" <woods%planix.ca@localhost>]

The following reply was made to PR port-i386/41267; it has been noted by GNATS.

From: "Greg A. Woods" <woods%planix.ca@localhost>
To: NetBSD GNATS <gnats-bugs%NetBSD.org@localhost>
Cc: port-i386-maintainer%netbsd.org@localhost, Jeff Rizzo 
<riz%netbsd.org@localhost>
Subject: Re: PR/41267 CVS commit: src/sys/arch/x86/x86
Date: Tue, 27 Nov 2012 20:13:38 -0800

 --pgp-sign-Multipart_Tue_Nov_27_20:13:38_2012-1
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: quoted-printable
 
 I don't know if this has showed up in anyone else's build yet, but the
 following change also must be pulled up to netbsd-5 in order to fix the
 kernel build errors below:
 
 
 RCS file: /cvs/master/m-NetBSD/main/src/sys/arch/x86/include/specialreg.h,v
 Working file: specialreg.h
 head: 1.60
 ----------------------------
 revision 1.58
 date: 2012/04/30 00:04:31;  author: christos;  state: Exp;  lines: +6 -1
 Add VIA Eden FCR MSR.
 ----------------------------
 
 
 m-NetBSD-5/sys/arch/x86/x86/identcpu.c: In function 'cpu_probe_winchip':
 m-NetBSD-5/sys/arch/x86/x86/identcpu.c:413: error: 'MSR_VIA_FCR' undeclared=
  (first use in this function)
 m-NetBSD-5/sys/arch/x86/x86/identcpu.c:413: error: (Each undeclared identif=
 ier is reported only once
 m-NetBSD-5/sys/arch/x86/x86/identcpu.c:413: error: for each function it app=
 ears in.)
 
 
 
 Any time anyone changes something like this, especially for a specific
 kernel on a release branch, it would be a very good idea to fire off a
 quick compile for at least the ALL or GENERIC config of that kernel
 _before_ running "cvs commit"!
 
 It seems the last "daily" snapshot build for the netbsd-5 branch was
 from a few days ago, back 2012-11-24, so it's not very useful for
 detecting these kinds of errors on release branches in a timely fashion.
 
 --=20
                                                Greg A. Woods
 
 +1 250 762-7675           <gwoods%acm.org@localhost>     RoboHack 
<woods%robohack.ca@localhost>
 Planix, Inc. <woods%planix.com@localhost>      Secrets of the Weird 
<woods%weird.com@localhost>
 
 --pgp-sign-Multipart_Tue_Nov_27_20:13:38_2012-1
 Content-Type: application/pgp-signature
 Content-Transfer-Encoding: 7bit
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.10 (NetBSD)
 
 iEYEABECAAYFAlC1j3IACgkQZn1xt3i/9H/uewCeLxoVdVUwT3P5+XLlm55EAuh9
 3+MAn3mpqWCXHtn98f98xdcX+jhxLOf5
 =p1+v
 -----END PGP SIGNATURE-----
 
 --pgp-sign-Multipart_Tue_Nov_27_20:13:38_2012-1--