Re: kern/47226: KASSERT while running t_faccessat on tmpfs mount

[Nicolas Joly <njoly%pasteur.fr@localhost>]

The following reply was made to PR kern/47226; it has been noted by GNATS.

From: Nicolas Joly <njoly%pasteur.fr@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/47226: KASSERT while running t_faccessat on tmpfs mount
Date: Thu, 22 Nov 2012 18:29:20 +0100

 On Wed, Nov 21, 2012 at 06:40:07PM +0000, J. Hannken-Illjes wrote:
 > The following reply was made to PR kern/47226; it has been noted by GNATS.
 > 
 > From: "J. Hannken-Illjes" <hannken%eis.cs.tu-bs.de@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc: 
 > Subject: Re: kern/47226: KASSERT while running t_faccessat on tmpfs mount
 > Date: Wed, 21 Nov 2012 19:39:27 +0100
 > 
 >  --Apple-Mail=_A72DD895-6759-4925-9D1F-D9E3B2750077
 >  Content-Transfer-Encoding: 7bit
 >  Content-Type: text/plain;
 >      charset=us-ascii
 >  
 >  Both fd_nameiat() and fd_nameiat_simple() call VOP_ACCESS() on
 >  an unlocked vnode which is wrong.
 >  
 >  The untested diff attached could fix it.
 
 It does, thanks !
 
 I had to make the same locking dance to do_sys_openat() which,
 likewise, calls VOP_ACCESS() without locking.
 
 panic: kernel diagnostic assertion "VOP_ISLOCKED(vp)"failed: file "/local/src/N
 etBSD/src/sys/fs/tmpfs/tmpfs_vnops.c",line 402
 cpu1: Begin traceback...
 kern_assert() at netbsd:kern_assert+0x48
 tmpfs_access() at netbsd:tmpfs_access+0x15f
 VOP_ACCESS() at netbsd:VOP_ACCESS+0x33
 do_sys_openat() at netbsd:do_sys_openat+0xbe
 sys_openat() at netbsd:sys_openat+0x22
 syscall() at netbsd:syscall+0x94
 --- syscall (number 468) ---
 7f7ff7039cda:
 cpu1: End traceback...
 
 -- 
 Nicolas Joly
 
 Biology IT Center
 Institut Pasteur, Paris.