[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: port-xen/47193: xenwatch handlers are added twice to the list of pending watches
>>>>> "Roger" == Roger Pau Monné <roger.pau%citrix.com@localhost> writes:
Roger> On 17/11/12 17:07, Cherry G.Mathew wrote:
>> Yes, but split() itself is not called unconditionally, whereas
>> malloc() is.
Roger> I've taken a quick look at this, and body is allocated in
Roger> process_msg. If message type is a watch, body is freed by
Roger> split, if it's not a watch, body is saved to
Roger> msg->u.reply.body, which is appended to the list of pending
Ok, you're right - the api uses asprintf() style buffer management.
Roger> Regarding the problem at hand, do you think the last patch is
Roger> ok to commit?
I don't see any problems (although we disagree on style, which is
Main Index |
Thread Index |