[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/46732: setroot(9) is called twice after "MI root on wedges" changes
The following reply was made to PR kern/46732; it has been noted by GNATS.
From: mlelstv%serpens.de@localhost (Michael van Elst)
Subject: Re: kern/46732: setroot(9) is called twice after "MI root on wedges"
Date: Sun, 22 Jul 2012 08:14:21 +0000 (UTC)
tsutsui%ceres.dti.ne.jp@localhost (Izumi Tsutsui) writes:
>Boot GENERIC kernel (also try boot with -a (RB_ASKNAME)).
>At least it happens on i386 and luna68k.
I see three possible solutions.
Drop setroot calls in MD code and adjust documentation (cpu_rootconf(9)).
cpu_rootconf is then only a hook that lets MD code set the variables
booted_device, booted_partition, booted_startblk, booted_blks.
Drop MI rootconf() and push detection of wedge 'aliases' into setroot().
Adjust setroot() signature to also pass in booted_startblk and booted_blks.
Change setroot() to only remember the root specification and make rootconf()
do the actual work with printing and RB_ASKNAME dance.
Michael van Elst
"A potential Snark may lurk in every tree."
Main Index |
Thread Index |