[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: port-sparc64/46652 (sparc ofwboot.net fails to load kernel viatftp)
The following reply was made to PR port-sparc64/46652; it has been noted by
From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
Subject: Re: port-sparc64/46652 (sparc ofwboot.net fails to load kernel viatftp)
Date: Thu, 5 Jul 2012 02:35:10 +0900
> > If the reason why it's int ** is too confusing, a comment should be added.
> > The code would be less clear to me, not more, if you handed over the
> > pointer to the entire open_file struct when all you want to do is set
> > one member of it (which is a dedicated "I'm void * so you can stick in
> > whatever both ends need", too).
> What kind of comment is reasonable for you?
> Even if you don't want void *, Why not int * but int **?
> I don't see any reason to prefer int **.
Ah, my bad, int * won't work here. I was actually confused...
But I still prefer passing struct open_file * as tftp_open().
Main Index |
Thread Index |