Re: port-sparc/46572: Invalid argument accessing qe* (qec) interfaces w/NetBSD-6.0_BETA2/sparc

["John D. Baker" <jdbaker%mylinuxisp.com@localhost>]

The following reply was made to PR port-sparc/46572; it has been noted by GNATS.

From: "John D. Baker" <jdbaker%mylinuxisp.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: port-sparc/46572: Invalid argument accessing qe* (qec) interfaces
 w/NetBSD-6.0_BETA2/sparc
Date: Wed, 20 Jun 2012 00:54:43 -0500 (CDT)

   This message is in MIME format.  The first part should be readable text,
   while the remaining parts are likely unreadable without MIME-aware tools.
 
 ---2139810480-1791951395-1340171683=:6758
 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
 
 The fault quickly converged on this commit:
 
    http://mail-index.netbsd.org/source-changes/2008/11/07/msg212329.html
 
 There are a lot of files modified in this, but the one of interest is
 "sys/dev/sbus/qe.c".  Despite comments about reusing "ether_ioctl()",
 not all the needed edits were made.
 
 The following change solves the problem.  It matches what was done
 for "be.c" as well as a number of other interface drivers affected
 by the above-referenced commit.
 
 Index: sys/dev/sbus/qe.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/sbus/qe.c,v
 retrieving revision 1.60
 diff -u -p -r1.60 qe.c
 --- sys/dev/sbus/qe.c  2 Feb 2012 19:43:06 -0000       1.60
 +++ sys/dev/sbus/qe.c  20 Jun 2012 04:35:44 -0000
 @@ -956,7 +956,7 @@ qeioctl(struct ifnet *ifp, u_long cmd, v
                break;
 
        default:
 -              error = EINVAL;
 +              error = ether_ioctl(ifp, cmd, data);
                break;
        }
 
 This is a diff against -current.  I'll include as an attachment
 as well so it can be applied with 'patch'.  Please also pull up
 to netbsd-6.
 
 Perhaps other less-commonly-used drivers from that commit should
 be double-checked?
 
 -- 
 |/"\ John D. Baker, KN5UKS               NetBSD     Darwin/MacOS X
 |\ / jdbaker[snail]mylinuxisp[flyspeck]com    OpenBSD            FreeBSD
 | X  No HTML/proprietary data in email.   BSD just sits there and works!
 |/ \ GPGkeyID:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645
 ---2139810480-1791951395-1340171683=:6758
 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=qeioctl-patch.diff
 Content-Transfer-Encoding: BASE64
 Content-ID: <Pine.NEB.4.64.1206200054430.6758%david.technoskunk.fur@localhost>
 Content-Description: qeioctl-patch.diff
 Content-Disposition: attachment; filename=qeioctl-patch.diff
 
 SW5kZXg6IHN5cy9kZXYvc2J1cy9xZS5jDQo9PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09DQpSQ1MgZmlsZTogL2N2c3Jvb3Qvc3JjL3N5cy9kZXYvc2J1cy9xZS5j
 LHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS42MA0KZGlmZiAtdSAtcCAtcjEu
 NjAgcWUuYw0KLS0tIHN5cy9kZXYvc2J1cy9xZS5jCTIgRmViIDIwMTIgMTk6
 NDM6MDYgLTAwMDAJMS42MA0KKysrIHN5cy9kZXYvc2J1cy9xZS5jCTIwIEp1
 biAyMDEyIDA0OjM1OjQ0IC0wMDAwDQpAQCAtOTU2LDcgKzk1Niw3IEBAIHFl
 aW9jdGwoc3RydWN0IGlmbmV0ICppZnAsIHVfbG9uZyBjbWQsIHYNCiAJCWJy
 ZWFrOw0KIA0KIAlkZWZhdWx0Og0KLQkJZXJyb3IgPSBFSU5WQUw7DQorCQll
 cnJvciA9IGV0aGVyX2lvY3RsKGlmcCwgY21kLCBkYXRhKTsNCiAJCWJyZWFr
 Ow0KIAl9DQogDQo=
 
 ---2139810480-1791951395-1340171683=:6758--