Re: kern/46592: lib/libc/sys/t_mmap cause kernel panic

[yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi)]

The following reply was made to PR kern/46592; it has been noted by GNATS.

From: yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi)
To: bouyer%antioche.eu.org@localhost
Cc: gnats-bugs%NetBSD.org@localhost, netbsd-bugs%NetBSD.org@localhost
Subject: Re: kern/46592: lib/libc/sys/t_mmap cause kernel panic
Date: Fri, 15 Jun 2012 02:51:36 +0000 (UTC)

 hi,
 
 > but it looks like the intend of the code was to set the size for both block 
 > and
 > char disk devices, so I'm not sure what the right thing to do here really is.
 
 good catch.
 
 unless we want to revive checkalias, a fix would be
        - use bdev_type for VBLK
        - defer sd_opencnt-- logic for VBLK to somewhere later so that
          it covers mmap.  probably spec_inactive?
        - before decrementing sd_opencnt, flush caches.
 
 YAMAMOTO Takashi