bin/46364: deprecated compile errors while building without pam

[Bernd Ernesti <pr201201%veego.de@localhost>]

>Number:         46364
>Category:       bin
>Synopsis:       deprecated compile errors while building without pam
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 22 09:15:00 +0000 2012
>Originator:     Bernd Ernesti
>Release:        NetBSD 6.0_BETA
>Organization:
>Environment:
System: NetBSD 6.0_BETA
Architecture: i386
Machine: i386
>Description:
        Compiling login(1), passwd(1) and su(1) without pam fails with the 
following errors:

        * login

src/usr.bin/login/login.c:86:21: fatal error: com_err.h: No such file or 
directory

src/usr.bin/login/k5login.c: In function 'k5_verify_creds':
src/usr.bin/login/k5login.c:167:10: error: 'krb5_get_err_text' is deprecated 
(declared at /usr/include/krb5/krb5-protos.h:2089)
src/usr.bin/login/k5login.c:196:10: error: 'krb5_get_err_text' is deprecated 
(declared at /usr/include/krb5/krb5-protos.h:2089)
src/usr.bin/login/k5login.c: In function 'k5_read_creds':
src/usr.bin/login/k5login.c:247:4: error: 'krb5_princ_realm' is deprecated 
(declared at /usr/include/krb5/krb5-protos.h:3203)
src/usr.bin/login/k5login.c:248:4: error: 'krb5_princ_realm' is deprecated 
(declared at /usr/include/krb5/krb5-protos.h:3203)
src/usr.bin/login/k5login.c:251:4: error: 'krb5_princ_realm' is deprecated 
(declared at /usr/include/krb5/krb5-protos.h:3203)
src/usr.bin/login/k5login.c:252:4: error: 'krb5_princ_realm' is deprecated 
(declared at /usr/include/krb5/krb5-protos.h:3203)
src/usr.bin/login/k5login.c: In function 'k5login':
src/usr.bin/login/k5login.c:376:4: error: 'krb5_get_err_text' is deprecated 
(declared at /usr/include/krb5/krb5-protos.h:2089)
src/usr.bin/login/k5login.c:382:4: error: 'krb5_get_err_text' is deprecated 
(declared at /usr/include/krb5/krb5-protos.h:2089)
src/usr.bin/login/k5login.c:388:4: error: 'krb5_get_err_text' is deprecated 
(declared at /usr/include/krb5/krb5-protos.h:2089)
src/usr.bin/login/k5login.c:395:4: error: 'krb5_get_err_text' is deprecated 
(declared at /usr/include/krb5/krb5-protos.h:2089)
src/usr.bin/login/k5login.c:405:4: error: 'krb5_princ_realm' is deprecated 
(declared at /usr/include/krb5/krb5-protos.h:3203)
src/usr.bin/login/k5login.c:406:4: error: 'krb5_princ_realm' is deprecated 
(declared at /usr/include/krb5/krb5-protos.h:3203)
src/usr.bin/login/k5login.c:409:4: error: 'krb5_princ_realm' is deprecated 
(declared at /usr/include/krb5/krb5-protos.h:3203)
src/usr.bin/login/k5login.c:410:4: error: 'krb5_princ_realm' is deprecated 
(declared at /usr/include/krb5/krb5-protos.h:3203)
src/usr.bin/login/k5login.c:413:4: error: 'krb5_get_err_text' is deprecated 
(declared at /usr/include/krb5/krb5-protos.h:2089)
src/usr.bin/login/k5login.c:421:4: error: 'krb5_get_err_text' is deprecated 
(declared at /usr/include/krb5/krb5-protos.h:2089)
src/usr.bin/login/k5login.c:430:2: error: 'krb5_get_in_tkt_with_password' is 
deprecated (declared at /usr/include/krb5/krb5-protos.h:2175)

        * passwd

src/usr.bin/passwd/krb5_passwd.c: In function 'krb5_chpw':
src/usr.bin/passwd/krb5_passwd.c:312:5: error: 'krb5_get_init_creds_opt_init' 
is deprecated (declared at /usr/include/krb5/krb5-protos.h:2235)

        * su

src/usr.bin/su/su.c: In function 'kerberos5':
src/usr.bin/su/su.c:465:2: error: 'krb5_cc_gen_new' is deprecated (declared at 
/usr/include/krb5/krb5-protos.h:627)
src/usr.bin/su/su.c:485:2: error: 'krb5_cc_gen_new' is deprecated (declared at 
/usr/include/krb5/krb5-protos.h:627)


>How-To-Repeat:
        Define 'USE_PAM = no' in /etc/mk.conf
        cd src/usr.bin/login
        make
        cd ../passwd
        make
        cd ../su
        make
>Fix:
        login.c is easy to fix, but the others should be fixed and pulled at 
the same time to the
        netbsd-6 branch too, so I leave that up to someone who solved the same 
issues after the
        new heimdal import last year

Index: login.c
===================================================================
RCS file: /cvsroot/src/usr.bin/login/login.c,v
retrieving revision 1.98
diff -b -u -r1.98 login.c
--- login.c     31 Aug 2011 16:24:57 -0000      1.98
+++ login.c     22 Apr 2012 08:44:15 -0000
@@ -83,7 +83,7 @@
 #endif
 #ifdef KERBEROS5
 #include <krb5/krb5.h>
-#include <com_err.h>
+#include <krb5/com_err.h>
 #endif
 #ifdef LOGIN_CAP
 #include <login_cap.h>