[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
port-sgimips/46311: sys/arch/sgimips/dev/imc.c refers to uninitialized mach_boardrev variable
>Synopsis: sys/arch/sgimips/dev/imc.c refers to uninitialized
>Arrival-Date: Sun Apr 08 23:35:00 +0000 2012
>Originator: Miod Vallat
sys/arch/sgimips/dev/imc.c will select different settings depending upon the
value of mach_boardrev, in the IP22/IP24 case. However this variable is never
set in machdep.c on those systems (and has a value of zero).
The affected logic is borrowed from Linux, which uses the board revision
computed from the IMC SysID register here.
Either initialize mach_boardrev in the IP22/IP24 case, or use the IMC SysID
register instead of mach_boardrev in the arbitration logic.
Main Index |
Thread Index |