NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

kern/46303: PUC devices not in pcidevs - hardcoded numbers in pucdata.c



>Number:         46303
>Category:       kern
>Synopsis:       PUC devices not in pcidevs - hardcoded numbers in pucdata.c
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 06 13:40:00 +0000 2012
>Originator:     Wolfgang Stukenbrock
>Release:        current (CVS-repository)
>Organization:
Dr. Nagler & COmpany GmbH
>Environment:
not relevant - found in CVS-repository
>Description:
In src/sys/dev/pci/pucdata.c there are lots of hardcoded devices-ID's for 
several vendors.
That all should be definitions from pcidevs.
Some affected vendors (not complete ..):
PCI_VENDOR_COMTROL
PCI_VENDOR_EXAR
PCI_VENDOR_LAVA
PCI_VENDOR_LUCENT
CPI_VENDOR_MOXA
....

If there are sets of chips that are matched by masking, there should be a 
comment that should note  the pcidevs-definitions that are matched.

>How-To-Repeat:
not relevant - found by a look into the CVS-repo
>Fix:
define symbolic names in picdevs and use that one.



Home | Main Index | Thread Index | Old Index