NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/46217: NetBSD 6.0_BETA hangs with CARP enabled



On Sat, Mar 24, 2012 at 03:08:56PM +0100, Manuel Bouyer wrote:
> 
> This is caused by ip_carp.c 1.42 -> 1.44; you actually can't sleep in
> the softclock thread because it will never wake up. The attached patch
> (reverting ip_carp.c 1.42 -> 1.44) fixes the problem for me.

I think we can remove the delay completely; please try the attached
patch instead

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--
Index: ip_carp.c
===================================================================
RCS file: /cvsroot/src/sys/netinet/ip_carp.c,v
retrieving revision 1.47
diff -u -p -u -r1.47 ip_carp.c
--- ip_carp.c   19 Nov 2011 22:51:25 -0000      1.47
+++ ip_carp.c   24 Mar 2012 16:30:22 -0000
@@ -1146,9 +1146,6 @@ carp_send_arp(struct carp_softc *sc)
 
                in = &ifatoia(ifa)->ia_addr.sin_addr;
                arprequest(sc->sc_carpdev, in, in, CLLADDR(sc->sc_if.if_sadl));
-
-               /* XXX: why does this need to delay? */
-               kpause("carpdel", false, MAX(1, mstohz(1)), NULL);
        }
        splx(s);
 }
@@ -1170,9 +1167,6 @@ carp_send_na(struct carp_softc *sc)
                in6 = &ifatoia6(ifa)->ia_addr.sin6_addr;
                nd6_na_output(sc->sc_carpdev, &mcast, in6,
                    ND_NA_FLAG_OVERRIDE, 1, NULL);
-
-               /* XXX: why does this need to delay? */
-               kpause("carpdel6", false, MAX(1, mstohz(1)), NULL);
        }
        splx(s);
 }


Home | Main Index | Thread Index | Old Index