Re: kern/46221: Kernel panic in NFS server code

["J. Hannken-Illjes" <hannken%eis.cs.tu-bs.de@localhost>]

The following reply was made to PR kern/46221; it has been noted by GNATS.

From: "J. Hannken-Illjes" <hannken%eis.cs.tu-bs.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: David Holland <dholland-bugs%netbsd.org@localhost>
Subject: Re: kern/46221: Kernel panic in NFS server code
Date: Fri, 23 Mar 2012 17:54:14 +0100

 On Mar 23, 2012, at 4:15 PM, David Holland wrote:
 
 > On Fri, Mar 23, 2012 at 09:05:04AM +0000, J. Hannken-Illjes wrote:
 >> Please try the attached diff that changes vn_lock() to return an invalid
 >> vnode only if the caller requested it by setting LK_RETRY.
 > 
 > Is this really what we want? Most callers of vn_lock don't check for
 > error.
 
 For now it should fix the error.  Any caller of vn_lock() has to either
 check for error OR pass LK_RETRY.  I'm not aware of any call violating
 this rule.
 
 > Also, it seems bogus for the vnode to be cleaned while we're holding a
 > reference to it.
 
 Sure, there is a race somewhere and once we get it fixed the change
 should become an assertion.
 
 --
 Juergen Hannken-Illjes - hannken%eis.cs.tu-bs.de@localhost - TU Braunschweig 
(Germany)