Re: PR/44847 CVS commit: src/sys/sys

[Klaus Klein <kleink%kleink.org@localhost>]

The following reply was made to PR standards/44847; it has been noted by GNATS.

From: Klaus Klein <kleink%kleink.org@localhost>
To: gnats-bugs%NetBSD.org@localhost, standards-manager%NetBSD.org@localhost,
        netbsd-bugs%NetBSD.org@localhost, jruohonen%iki.fi@localhost
Cc: christos%NetBSD.org@localhost
Subject: Re: PR/44847 CVS commit: src/sys/sys
Date: Sun, 18 Mar 2012 21:53:09 +0100

 On Sun, Mar 18, 2012 at 02:06:06PM +0200, Jukka Ruohonen wrote:
 > On Sun, Mar 18, 2012 at 12:00:07PM +0000, Martin Husemann wrote:
 > > The following reply was made to PR standards/44847; it has been noted by 
 > > GNATS.
 > > 
 > > From: Martin Husemann <martin%homeworld.netbsd.org@localhost>
 > > To: gnats-bugs%NetBSD.org@localhost
 > > Cc: christos%NetBSD.org@localhost, jruohonen%iki.fi@localhost
 > > Subject: Re: PR/44847 CVS commit: src/sys/sys
 > > Date: Sun, 18 Mar 2012 11:57:03 +0000
 > > 
 > >  On Sat, Mar 17, 2012 at 09:35:02PM +0000, Christos Zoulas wrote:
 > >  >  Log Message:
 > >  >  PR/44847: Jukka Ruohonen: blksize_t should be signed.
 > >  >  
 > > http://pubs.opengroup.org/onlinepubs/000095399/basedefs/sys/types.h.html
 > >  
 > >  I object to this change, that part of the standard is obviously bogus
 > >  and should not be blindly followed.
 > 
 > I agree; it seems to me that this was inherited from whatever system was
 > used as a base at the time of standardization (Solaris, AIX, or something).
 
 And in the spirit of standadizing existing practice, so did 4.3BSD for
 that matter.  It wasn't until 4.4 that stat.st_blksize got changed from
 signed long to unsigned long.  (I should have looked up that detail
 earlier, sorry.)
 
 
 - Klaus